Opened 13 years ago

Closed 12 years ago

#19 closed defect (fixed)

Update Atten. Rel. Plotter app

Reported by: Peter Powers Owned by: Kevin Milner
Priority: major Milestone: OpenSHA 1.1
Component: build-process Version:
Keywords: Cc: Ned Field


No attenRelationships located in 'scratch' should be included in public application.

Change History (7)

comment:1 Changed 12 years ago by Kevin Milner

Cc: Ned Field added

Current (as of 12/2/10) IMRs that are used in apps but aren't in our default package are:

In Atten Rel Plotter app:

  • scratch.christine.attenRelImpl.BS_2003b_AttenRel
  • scratch.jennie.attenRelImpl.ToroEtAl_1997_AttenRel

In Hazard Apps:

  • org.opensha.gem.GEM1.scratch.ZhaoEtAl_2006_AttenRel

Should these be removed from the apps, or moved to org.opensha.sha.imr.attenRelImpl (possibly with an "UNVERIFIED!" label)? Is it OK to leave the GEM one where it is?

Ned, Peter...thoughts?

comment:2 Changed 12 years ago by Peter Powers

I don't have a position on this. I would like to see all ERF's and IMR's available from an enum. This would avoid having to use reflection to get AttenRel?.NAME as the AttenRel?.NAME could be provided in the enum constructor and made available via toString() or getName(). One could also have a newInstance() method that would do just that. Moreover, a verified() method could be included to filter those attenRels out in applications. Perhaps a preference/control panel could then be used to make them available.

comment:3 Changed 12 years ago by Kevin Milner

I like that idea Peter! I created a new ticket for it...#98

comment:4 Changed 12 years ago by Ned Field

I think we ditch the first two ones from our apps, but lets ask the GEM folks about theirs because I'd like to keep that one (especially if they can give us a verification table to use in a Junit test).

I don't have a problem with changing how the apps access the desired IMRs or ERFs as long as it's clear and easy for anyone to add one (e.g., when they're prototyping in scratch).

comment:5 Changed 12 years ago by Kevin Milner

OK I removed the scratch ones from the atten rel app. Now there's just the GEM one in the hazard apps. I agree that it'd be nice to keep, especially since it's the only one in the apps that supports subduction sources!

comment:6 Changed 12 years ago by Ned Field

The other one (Zhao) I'd move into the main code and mark as UNVERIFIED in its name (as suggested above)

comment:7 Changed 12 years ago by Kevin Milner

Resolution: fixed
Status: newclosed

I moved Zhao in [7306] and marked it as UNVERIFIED in [7307]. Closing this ticket (although Zhao still has to be verified, but that's now in #101).

Note: See TracTickets for help on using tickets.