Opened 10 years ago

Closed 10 years ago

#470 closed defect (fixed)

AttenuationRelationship assumes that func.get(i).setLocation(x,y) will update underlying func (CRITICAL)

Reported by: Kevin Milner Owned by: Kevin Milner
Priority: critical Milestone:
Component: sha Version:
Keywords: Cc:


AttenuationRelationship?.getExceedProbabilities(...) updates the passed in function by getting Point2D values, and then calling setLocation. This is not (or at least should not be) part of the DiscretizedFunc? specification, as some functions are not (and have never been) backed by Point2Ds - for example evenly discretized functions. This is a big bug that has affected any hazard curve calculations in the last 2 weeks (since the switch to the fixed x value function in the calc code), and any prior curve calculations or imr.getExceedProbabilities calls that were done with evenly discretized x values (uncommon).

We definitely got lucky that the unit tests last night caught this bug.

Change History (1)

comment:1 Changed 10 years ago by Kevin Milner

Resolution: fixed
Status: newclosed

fixed in [10749]

Note: See TracTickets for help on using tickets.