Opened 12 years ago

Closed 9 years ago

#400 closed defect (fixed)

AbstractXY_DataSet.getClosestX(double y)

Reported by: Ned Field Owned by: Kevin Milner
Priority: minor Milestone: OpenSHA 1.4
Component: sha Version:
Keywords: Cc:


this method should be renamed to getClosestXtoY(double y)

(because I thought it would find the closest allowed x value for an arbitrary x)

In other words, I thought it returned:

getX(getClosestXIndex(x)), but it actually returns the x-axis value that is closest to a given y value.

Change History (4)

comment:1 Changed 12 years ago by Peter Powers

Agreed. getClosestX(y) isn't actually used; only it's complement getClosestY(x) is.

Both methods should have their signatures added to the XY_DataSet interface.

comment:2 Changed 10 years ago by Kevin Milner

Milestone: OpenSHA 1.3OpenSHA 1.4

closely related to #394 and #395, future cleanup needed

comment:3 Changed 9 years ago by Kevin Milner

Done in [10915] in XY dataset refactoring branch (branches/2015_01-xy-dataset-refactor). Will close when other changes are done and merged back to trunk.

comment:4 Changed 9 years ago by Kevin Milner

Resolution: fixed
Status: newclosed

Fixes/updates merged to trunk in [10931], closing.

Note: See TracTickets for help on using tickets.