Opened 12 years ago
Closed 10 years ago
#400 closed defect (fixed)
AbstractXY_DataSet.getClosestX(double y)
| Reported by: | Ned Field | Owned by: | Kevin Milner |
|---|---|---|---|
| Priority: | minor | Milestone: | OpenSHA 1.4 |
| Component: | sha | Version: | |
| Keywords: | Cc: |
Description
this method should be renamed to getClosestXtoY(double y)
(because I thought it would find the closest allowed x value for an arbitrary x)
In other words, I thought it returned:
getX(getClosestXIndex(x)), but it actually returns the x-axis value that is closest to a given y value.
Change History (4)
comment:1 Changed 12 years ago by
comment:2 Changed 11 years ago by
| Milestone: | OpenSHA 1.3 → OpenSHA 1.4 |
|---|
comment:3 Changed 10 years ago by
Done in [10915] in XY dataset refactoring branch (branches/2015_01-xy-dataset-refactor). Will close when other changes are done and merged back to trunk.
comment:4 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixes/updates merged to trunk in [10931], closing.
Note: See
TracTickets for help on using
tickets.
Agreed. getClosestX(y) isn't actually used; only it's complement getClosestY(x) is.
Both methods should have their signatures added to the XY_DataSet interface.