Opened 12 years ago

Closed 12 years ago

#374 closed defect (fixed)

AB2006_140 setParamDefaults doesn't correctly set Stress Drop parameter

Reported by: Kevin Milner Owned by: Peter Powers
Priority: major Milestone: OpenSHA 1.3
Component: sha Version:
Keywords: Cc:

Description

I have a test that makes sure that the setParamDefaults method of every IMR actually sets each value to the param.getDefaultValue() for each parameter (assuming that getDefaultValue() doesn't return null). This fails for the Stress Drop parameter of AB2006_140. You can test this by running the GeneralIMR_ParameterTests test, failure trace below.

Peter, can you fix this? It's the last failure in our nightly coverage tests (I fixed the other error, see #373).

java.lang.AssertionError: AB2006_140: param 'Stress Drop' value is not set to default when setParamDefaults() called.
default: 140 bar
value: 200 bar expected:<140 bar> but was:<200 bar>
	at org.junit.Assert.fail(Assert.java:91)
	at org.junit.Assert.failNotEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:126)
	at org.opensha.sha.imr.attenRelImpl.test.GeneralIMR_ParameterTests.testParamsInit(GeneralIMR_ParameterTests.java:151)
	...

Change History (1)

comment:1 Changed 12 years ago by Peter Powers

Resolution: fixed
Status: newclosed

Fixed in [8434]. There still errors related to PropEffectSpeedup? param not existing, but that is a separate issue from this ticket.

Note: See TracTickets for help on using tickets.