Opened 13 years ago

Closed 11 years ago

#342 closed enhancement (fixed)

Cleanup Regions

Reported by: Peter Powers Owned by: Peter Powers
Priority: minor Milestone: OpenSHA 1.3
Component: sha Version:
Keywords: Cc:

Description

1) Cleanup access to CA regions via factory get methods. Privatize nested classes.

2) Factory for regions: rect, circular, sausage, etc.... OR separate classes.

3) Option flag for rect regions to expand border to include points on northern and eastern borders

Change History (2)

comment:1 Changed 11 years ago by Kevin Milner

Ready to close or more work needed? Here's how I see the state of all 3 issues identified:

1) Cleanup access to CA regions via factory get methods. Privatize nested classes.

  • this has been done

2) Factory for regions: rect, circular, sausage, etc.... OR separate classes.

  • this has not been done, still desired? currently handled as multiple constructors

3) Option flag for rect regions to expand border to include points on northern and eastern borders

  • no option flag exists, but rectangular regions are automatically expanded to include such points

comment:2 Changed 11 years ago by Peter Powers

Resolution: fixed
Status: newclosed

Closing as a mix of fixed and won't fix.

Note: See TracTickets for help on using tickets.