Opened 13 years ago

Closed 13 years ago

#279 closed defect (fixed)

Rename ERF interfaces to remove 'API'

Reported by: Kevin Milner Owned by: Peter Powers
Priority: major Milestone: OpenSHA 1.2
Component: sha Version:
Keywords: Cc:

Description

ERF interfaces should not contain "API" in the file name. Also "Abstract" should proceed abstract implementation names.

Change History (7)

comment:1 Changed 13 years ago by Kevin Milner

Milestone: → OpenSHA 1.2

comment:2 Changed 13 years ago by Kevin Milner

Here's a proposed change from discussion with Peter:

EqkRupForecastBaseAPI -> EqkRupForecast??

EqkRupForecast?? -> AbstractSourceERF
EqkRupForecastAPI -> SourceERF

ERF_EpistemicList -> AbstractListERF
ERF_EpistemicListAPI -> EpistemicListERF

EqkSourceAPI -> EqkSource??

comment:3 Changed 13 years ago by Peter Powers

Keeping in mind that it the second level interfaces are what will be used to identify collections of ERF's, here are some possibilities:

EqkRupForecast (I)
    |
    |-- ERF or SimpleERF or BaseERF (I)
    |     |
    |     |-- AbstractERF
    |
    |-- ListERF or EpistemicListERF (I) 
          |
          |-- AbstractListERF

comment:4 Changed 13 years ago by Ned Field

Peter and Ned agreed on:

BaseERF (I)
    |
    |-- ERF (I)
    |     |
    |     |-- AbstractERF
    |
    |-- EpistemicListERF (I) 
          |
          |-- AbstractEpistemicListERF

comment:5 Changed 13 years ago by Kevin Milner

OK. I can implement this today (unless you've already started, Peter).

comment:6 Changed 13 years ago by Peter Powers

Have at it!

comment:7 Changed 13 years ago by Kevin Milner

Resolution: → fixed
Status: new → closed

OK done in [7906].

Note: See TracTickets for help on using tickets.