Opened 12 years ago
Last modified 9 years ago
#270 new enhancement
Refactor custom sha exceptions as JRE exceptions
Reported by: | Peter Powers | Owned by: | Peter Powers |
---|---|---|---|
Priority: | major | Milestone: | OpenSHA 2.0 |
Component: | commons | Version: | |
Keywords: | Cc: |
Description
Ideally we can do away with all custom exceptions, however, that involves quite a bit of work including but not limited to:
EditableException? -> IllegalStateException? throw with checkState()
ConstraintException? -> IllegalArgumentException? throw with multiple checkArgument()s
FaultException? -> IllegalArgumentException? throw with multiple checkArgument()s
GMT_MapException -> ok or sub with multiple exception types
IMRException -> generally masks NPEs
InvalidRangeException? -> IllegalArgumentException? throw with multiple checkArgument()s
ParameterException? -> IllegalArgumentException? throw with multiple checkArgument()s
Point2DException -> IllegalArgumentException? throw with multiple checkArgument()s
WarningException? -> requires reworking of parameter-editor relationship
XY_DataSetException -> IllegalArgumentException? throw with multiple checkArgument()s
The many references to InvalidRangeException?, ParameterException?, Point2DException, and XY_DataSetException almost universally point back up to constructors or setValue() methods where IllegalArgumentExceptions? should be used instead.
removed XY_DataSetException and Point2DException as part of #395