Simplify PropagationEffectParameter interface/abstract hierarchy

[Peter Powers]

The concrete implementations of PropagationEffectParameter? are all double valued. Was there an assumption early on that there might be any type of value associated with a propagation effect?. In the future this may be the case, but for now the abstract class and interface hierarchy is messy with numerous duplicated methods in classes such as WarningDoublePropagationEffectParameter?.

Adjust PropagationEffectParameter? to inherit from WarningDoubleParameter? then most of the work is done for all the Dist* parameters. The PropagationEffectParameterAPI is also unnecessary at this time.

[Ned Field]

There will be non-double propagation parameters (e.g., a boolean stating whether a site is on the hanging wall)

[Peter Powers]

• Initial restructuring; created AbstractDoublePropEffectParam? and AbstractBooleanPropEffectParam?
• Eliminated unused methods in PropogationEffectParameterAPI

in [7517] and [7518]

[Peter Powers]

The above changes were a good start. On a related note (#36) I would like to have the distances calculated by any distance param and it's complement in PropEffect? reference the same (static?) method to guarantee that their both always doing the same thing.

Other tickets related to PropEffect?: #36 #131

[Ned Field]

RE "I would like to have the distances calculated by any distance param and it's complement in PropEffect?? reference the same (static?) method to guarantee that their both always doing the same thing"

This would lose the efficiency provided by PropEffect?, which was the purpose of creating it in the first place. I don't think that slight redundancy is a big deal.

[Peter Powers]

Yes, as stated I see what you mean. PropEffect? locally computes horzDist and rupDist only once whereas it would be repeated if separated out for each distance metric. I'd only advocate separating out the redundant parts if it will improve clarity and testability.

[Kevin Milner]

Marking this as fixed as distance calcs are now done by rupture surfaces themselves