Opened 13 years ago
Closed 13 years ago
#134 closed defect (fixed)
Switch important parameter editors over to NewParameterEditor, then rename
Reported by: | Kevin Milner | Owned by: | Kevin Milner |
---|---|---|---|
Priority: | major | Milestone: | OpenSHA 1.2 |
Component: | commons | Version: | |
Keywords: | Cc: |
Description (last modified by )
The major parameter editors (integer, string, double, etc...) should be switched over to the new parameter editor class. Once this is done, we can deprecate the old one and maybe rename as such:
ParameterEditor? -> OldParameterEditor?
NewParameterEditor? -> ParameterEditor?
Parameters already migrated:
- IntegerParameterEditor?
- ConstrainedIntegerParameterEditor?
- DoubleParameterEditor?
- ConstrainedDoubleParameterEditor?
- StringParameterEditor?
- ConstrainedStringParameterEditor?
- ConstrainedDoubleDiscreteParameterEditor?
- BooleanParameterEditor?
- ParameterListParameterEditor?
- ArbitrarilyDiscretizedFuncParameterEditor?
Change History (4)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Owner: | changed from Peter Powers to Kevin Milner |
Status: | new → assigned |
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 13 years ago by
Description: | modified (diff) |
---|
migrated ParameterListParameterEditor? and removed LocationParameterEditor? in [7561]...LocationParameter? now just creates a ParameterListParameterEditor?.
comment:4 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
updated ArbitrarilyDiscretizedFuncParameterEditor? in [7562]...going to close as I believe the important ones have been migrated. I also marked ParameterEditor? as deprecated in [7563]. Not going to rename in the foreseeable future for compatibility.
There may be some oddball editors that we choose to migrate in the future, but we can deal with that when the time comes.
migrated ConstrainedDoubleDiscreteParameterEditor? and BooleanParameterEditor? in [7507] and [7508] respectively.