id,summary,reporter,owner,description,type,status,priority,milestone,component,version,resolution,keywords,cc 391,Bug in GriddedSubsetSurface's distance X calculation,Kevin Milner,,"I noticed an apparent bug in the caching for GriddedSubsetSurface while investigating #390. DistanceX uses a different cache but the getDistanceX method was being called with the regular cached location, siteLocForDistCalcs, instead of siteLocForDistXCalc. This means that our distance X calculations have potentially been off any time that distance X is calculated before any of the other distance metrics for a given site. Any results since the new surface implementation was added where values for multiple sites were calculated could be affected by this bug. {{{ public synchronized double getDistanceX(Location siteLoc){ if(!siteLocForDistXCalc.equals(siteLoc)) { siteLocForDistXCalc = siteLoc; distanceX = GriddedSurfaceUtils.getDistanceX(getEvenlyDiscritizedUpperEdge(), siteLocForDistCalcs); } return distanceX; } }}}",defect,closed,critical,OpenSHA 1.3,sha,,fixed,,